MCLOUD-5818: Fix for composer running out of memory in container #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge head repo to base repo
shiftedreality
suggested changes
Apr 16, 2020
michaelcasey316
suggested changes
Apr 16, 2020
There was a problem hiding this comment.
I agree with @shiftedreality. Having this adjustable in docker-compose.yml or the Dockerfile would be ideal.
|
I suppose it is fair to say that if we are setting a default in the
containers, we should expose it in the Dockerfile so that it can be used
from docker commands easily.
If we had a styleguide, this would be a good rule it seems. Thanks for the
feedback @michaelcasey316 and @shiftedreality
<https://github.com/shiftedreality>.
…On Thu, Apr 16, 2020 at 11:55 AM Michael Casey ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I agree with @shiftedreality <https://github.com/shiftedreality>. Having
this adjustable in docker-compose.yml or the Dockerfile would be ideal.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#197 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6NE54M4ZLLNS6BVIJ2W3RM4S5LANCNFSM4MIPMCKA>
.
|
|
@shiftedreality Requested changes are implemented. |
mveeramneni
changed the title
shiftedreality
suggested changes
Apr 22, 2020
|
@shiftedreality Now only the composer memory limit is set as environment variable without any ini file changes. |
michaelcasey316
approved these changes
Apr 23, 2020
shiftedreality
approved these changes
Apr 27, 2020
|
@shiftedreality Maybe make sense to merge this PR first #198 and update current PR? Otherwise we should create task task to update COMPOSER_MEMORY_LIMIT -1 for php 7.4 or fix memory limit in PR with php 7.4 image. |
|
Approved |
andriyShevtsov
added
Progress: accept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MCLOUD-5818 :
This fixes composer running out of memory when installing multiple packages through cloud docker
Fixed Issues (if relevant)
Contribution checklist